Review Request 254: [1/1] Add LMI_MountConfigurationService.

Jan Safranek reviewboard at gallagherhome.com
Thu Apr 25 11:17:46 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/254/#review294
-----------------------------------------------------------



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment193>

    It would be nice to say also *which* parameter is empty.



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment187>

    the affected elements are CIMInstanceNames of elements, which are being used/modified during the transaction, i.e. param_filesystem (if specified).



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment188>

    If you return 'Mount' here, it means that the instance is already available and application can call GetInstance on it. If I understand it correctly, the MountedFileSystem will be available only after the job finishes. So don't return it here, but add it to outparams when the job finishes.



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment189>

    Fill a RFE or create a patch... Adding XXX to code won't help anything :)



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment191>

    either return non-positive 'rval' or set error, not both. IMHO it's enough to 'raise CIMError(...), the job will handle the rest automatically.
    
    Dtto for DeleteMount.



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment190>

    Feel free to raise the error, otherwise the application might get an impression that everything is OK.
    
    Dtto for DeleteMount.



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment192>

    Put the created mount point here as outparam.



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment194>

    Again, CIMInstanceName of the affected MountedFileSystem should be in affected_elements



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment195>

    IMHO it works now



src/openlmi/storage/LMI_MountConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment196>

    Throw error instead.
    
    And again, fill RFE.



src/openlmi/storage/MountingProvider.py
<http://reviewboard-openlmi.rhcloud.com/r/254/#comment197>

    OK, why not, but let other mounting classes use it too.


- Jan Safranek


On April 24, 2013, 2:15 p.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/254/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 2:15 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Add LMI_MountConfigurationService.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Storage.reg e0eb237150618f0e561294d1d5354857ddf23adf 
>   src/openlmi/storage/LMI_MountConfigurationService.py PRE-CREATION 
>   src/openlmi/storage/MountingProvider.py PRE-CREATION 
>   src/openlmi/storage/cimom_entry.py 7157f7d21dff4751905e9f36d115e57d2f397a9d 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/254/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130425/faa391e9/attachment-0001.html>


More information about the openlmi-devel mailing list