Review Request 248: openlmi-networking [5/6] test: Fix tests for new connection creation API
Jan Safranek
reviewboard at gallagherhome.com
Mon Apr 22 14:13:46 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/248/#review280
-----------------------------------------------------------
Ship it!
Ship It!
test/test_create_destroy_connection.py
<http://reviewboard-openlmi.rhcloud.com/r/248/#comment169>
The test looks OK, but from API point of viwe, shouldn't there be async call + indication instead of random sleep?
- Jan Safranek
On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/248/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 2:41 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-networking
>
>
> Description
> -------
>
> test: Fix tests for new connection creation API
>
>
> Diffs
> -----
>
> test/test_apply_connection.py 55b9ecb333871c646bed4af1436d8c725c1ad3dc
> test/test_create_destroy_connection.py c93d336ece1ceb0e968e8c0e940891beb3a4e374
> test/test_enable_disable_iface.py 832b7cdb9fd5ab6b008fd2fe31a4f78069510ee8
> test/test_modify_connection.py ab43a0caeaeaf0c24be1b844a1e28cb5a421d857
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/248/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130422/e56214cc/attachment.html>
More information about the openlmi-devel
mailing list