Review Request 241: openlmi-software:indications [4/5] modified indication filters

Jan Safranek reviewboard at gallagherhome.com
Fri Apr 19 15:01:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/241/
-----------------------------------------------------------

(Updated April 19, 2013, 5:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

modified indication filters

Indication filters now reflect the name of indication class, which is
instrumented by particular provider. This ensures, that cimom knows,
which provider to call and does not bother the others. So instead of
selecting indication instances from general class CIM_InstModification,
it will be LMI_SoftwareInstModification. This is a common pattern for
indication queries.

Avoided another shortcoming of sfcbmof parser:
  /* comment */ something useful is also ignored :-(


Diffs
-----

  mof/70_LMI_SoftwareIndicationFilters.mof e3af599dbd921ab0224154008aed04027a805a32 
  src/python/openlmi/common/IndicationManager.py b51737386ab05c156fa72ee3e55b0dc137811023 
  src/software/openlmi/software/yumdb/jobmanager.py 7283d054028b29c0e101a6b0515b42bc3a550317 

Diff: http://reviewboard-openlmi.rhcloud.com/r/241/diff/


Testing
-------


Thanks,

Michal Minar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130419/49f2f52d/attachment.html>


More information about the openlmi-devel mailing list