Review Request 230: [1/1] Replace eval() with ast.literal_eval().

Radek Novacek reviewboard at gallagherhome.com
Wed Apr 17 12:05:42 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/230/#review256
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On April 17, 2013, 1:50 p.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/230/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 1:50 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Replace eval() with ast.literal_eval().
> 
> This can be used for safely evaluating strings containing Python expressions
> from untrusted sources without the need to parse the values oneself.
> 
> 
> Diffs
> -----
> 
>   src/openlmi/storage/SettingProvider.py 2aafb2c14b756814b64665ec325920bd47289326 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130417/0caa67c5/attachment.html>


More information about the openlmi-devel mailing list