Review Request 185: openlmi-providers: Support for using libopenlmicommon by external providers

Radek Novacek reviewboard at gallagherhome.com
Wed Apr 17 10:32:09 UTC 2013



> On April 15, 2013, 5:30 p.m., Jan Safranek wrote:
> > src/openlmi.c, lines 136-137
> > <http://reviewboard-openlmi.rhcloud.com/r/185/diff/2/?file=1156#file1156line136>
> >
> >     This would be a tiny bit nicer in one fprintf call.

Fixed.


- Radek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/185/#review217
-----------------------------------------------------------


On April 15, 2013, 10:14 a.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/185/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 10:14 a.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Support for using libopenlmicommon by external providers
> 
> * add FindOpenLMI.cmake module
> * add pkgconfig for OpenLMI
> * rename globals.c/h to openlmi.c/h
> * add symlink with major version to openlmicommon library
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=948948
> 
> 
> Diffs
> -----
> 
>   src/globals.c 7e58817fbaf87d25d4ec343d8589ec74f1224a8b 
>   src/globals.h a1cb18c5421da17be4892322c96778d5cc8a05e8 
>   src/fan/LMI_FanSensorProvider.c 47bd9d529931adc4ac6a1b15d759067bb63f324a 
>   src/fan/LMI_FanAssociatedSensorProvider.c d75bf5cc39b8a28d17980ab763d48831d762387c 
>   src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 
>   cmake/modules/FindOpenLMI.cmake PRE-CREATION 
>   CMakeLists.txt 230ed263388a62fe4a293479ca7bb9744e3fcfd9 
>   src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
>   src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
>   src/hardware/lscpu.h 5dc5bd5cbf01471ce8a6e98ba8f93386336a3898 
>   src/hardware/sysfs.h 0e0b523ec6918b028ae0b17b9c756b76e2e686e8 
>   src/openlmi.h PRE-CREATION 
>   src/openlmi.c PRE-CREATION 
>   src/openlmi.pc.in PRE-CREATION 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/185/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130417/7512583b/attachment.html>


More information about the openlmi-devel mailing list