Review Request 225: [4/6] Add LMI_MountedFileSystem, LMI_HostedMount and the setting classes.

Jan Safranek reviewboard at gallagherhome.com
Wed Apr 17 09:22:45 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/225/#review246
-----------------------------------------------------------



src/openlmi/storage/LMI_HostedMount.py
<http://reviewboard-openlmi.rhcloud.com/r/225/#comment151>

    You should also check that it is the device what's mounted at the path.



src/openlmi/storage/LMI_MountedFileSystem.py
<http://reviewboard-openlmi.rhcloud.com/r/225/#comment152>

    You should check that it's the device what's mounted at the path.



src/openlmi/storage/LMI_MountedFileSystem.py
<http://reviewboard-openlmi.rhcloud.com/r/225/#comment154>

    You use 'spec, path = self._parse_id(mountid)' in get_associated_element_name, this looks inconsistent.


- Jan Safranek


On April 17, 2013, 10:10 a.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/225/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 10:10 a.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Add LMI_MountedFileSystem, LMI_HostedMount and the setting classes.
> 
> The LMI_MountedFileSystemSetting class and its association are implemented
> inside the LMI_MountedFileSystem.
> 
> 
> Diffs
> -----
> 
>   src/openlmi/storage/LMI_HostedMount.py PRE-CREATION 
>   src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION 
>   src/openlmi/storage/cimom_entry.py 940ab512d528810012c941f218627c61f5a322f7 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/225/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130417/9731e4a7/attachment.html>


More information about the openlmi-devel mailing list