Review Request 195: Hardware: Added System Memory Provider

Jan Safranek reviewboard at gallagherhome.com
Wed Apr 17 08:52:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/195/#review238
-----------------------------------------------------------



src/hardware/LMI_MemoryProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/195/#comment144>

    It should be LMI:LMI_Memory:0, not :Memory:



src/hardware/dmidecode.h
<http://reviewboard-openlmi.rhcloud.com/r/195/#comment145>

    These modules are only parsed, but they are never used. Is it something you're going to work on in the future?



src/hardware/dmidecode.c
<http://reviewboard-openlmi.rhcloud.com/r/195/#comment143>

    What's purpose of this check? 'continue' has no effect here, the loop ends after 'if' anyway.


- Jan Safranek


On April 15, 2013, 7:02 p.m., Peter Schiffer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/195/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 7:02 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Hardware: Added System Memory Provider
> 
> Added new provider:
>  * LMI_MemoryProvider
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Hardware.mof 0964291c81b029d17d4945f9faead08e11005ff7 
>   src/hardware/CMakeLists.txt 3949a8ad704581f5d0e9a88ac5fa369511a041ee 
>   src/hardware/LMI_Hardware.h 1f30be648ec59f02a4d4ad67aea4a9c6a958d216 
>   src/hardware/LMI_MemoryProvider.c PRE-CREATION 
>   src/hardware/LMI_ProcessorCacheMemoryProvider.c afc5d7f0488c506dddabd438f7af56578f464856 
>   src/hardware/LMI_ProcessorProvider.c 99b0fad7d1e36efbb1e823d20cda74bf9b577235 
>   src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
>   src/hardware/cpuinfo.c 6634b059df7d858654c862e88a705bbc574edef0 
>   src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
>   src/hardware/dmidecode.c 348c7a23b76f42ab5dae78a86e42c69789a4e021 
>   src/hardware/procfs.h PRE-CREATION 
>   src/hardware/procfs.c PRE-CREATION 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/195/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter Schiffer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130417/27f802b8/attachment-0001.html>


More information about the openlmi-devel mailing list