Review Request 186: service: added dbus based service provider [1/1] service: added dbus based service provider

Jan Safranek reviewboard at gallagherhome.com
Wed Apr 17 08:14:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/186/#review236
-----------------------------------------------------------



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment137>

    why not strdup? It runs strlen internally.



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment138>

    please check str(n)dup results for NULL, it's like malloc.



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment141>

    This function allocates lot of data (strdup), I haven't found a place where it's released.



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment140>

    rename to value_long?



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment139>

    check for strdup results


- Jan Safranek


On April 11, 2013, 5:23 p.m., Vitezslav Crhonek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/186/
> -----------------------------------------------------------
> 
> (Updated April 11, 2013, 5:23 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> service: added dbus based service provider
> 
> 
> Diffs
> -----
> 
>   README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 
>   src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076 
>   src/service-dbus/CMakeLists.txt PRE-CREATION 
>   src/service-dbus/LMI_ServiceProvider.c PRE-CREATION 
>   src/service-dbus/util/serviceutil.h PRE-CREATION 
>   src/service-dbus/util/serviceutil.c PRE-CREATION 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitezslav Crhonek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130417/91912bd0/attachment.html>


More information about the openlmi-devel mailing list