Review Request 214: 'Touch' used settings in all methods.

Radek Novacek reviewboard at gallagherhome.com
Tue Apr 16 12:57:17 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/214/#review230
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On April 16, 2013, 2:44 p.m., Jan Safranek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/214/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 2:44 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> 'Touch' used settings in all methods.
> 
> If a method uses Setting object, we must restart its timer for garbage
> collection.
> 
> 
> Diffs
> -----
> 
>   src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py 4087de3e0cc3ab20fea9176a3ee43fad3cd25354 
>   src/openlmi/storage/LMI_FileSystemConfigurationService.py 32f15febfaab9528f974081c503eb588b89c2f0a 
>   src/openlmi/storage/LMI_StorageConfigurationService.py 8ea10fbff155d627873c71bd09890a1bb1bb5341 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/214/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Safranek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130416/2883630c/attachment.html>


More information about the openlmi-devel mailing list