Review Request 130: [2/10] Add LMI_MountedFileSystem and LMI_HostedMount.

Jan Synacek reviewboard at gallagherhome.com
Tue Apr 16 08:37:56 UTC 2013



> On April 9, 2013, 4:47 p.m., Jan Safranek wrote:
> > src/openlmi/storage/MountingProvider.py, lines 44-45
> > <http://reviewboard-openlmi.rhcloud.com/r/130/diff/1/?file=724#file724line44>
> >
> >     If I read it correctly, this says that if a device is not mounted, it's still added to list of mounts. Is this correct? It sounds weird to me.

Yes. It's totally wrong, I'll remove it.


> On April 9, 2013, 4:47 p.m., Jan Safranek wrote:
> > src/openlmi/storage/MountingProvider.py, lines 41-42
> > <http://reviewboard-openlmi.rhcloud.com/r/130/diff/1/?file=724#file724line41>
> >
> >     device.parents is not related with filesystem on the device in any way, why is the check here?

This was there to prevent the parent device from displaying. A modified the code slightly so it's not needed there anymore.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/130/#review135
-----------------------------------------------------------


On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/130/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 3:22 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Add LMI_MountedFileSystem and LMI_HostedMount.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 
>   src/openlmi/storage/LMI_HostedMount.py PRE-CREATION 
>   src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION 
>   src/openlmi/storage/MountingProvider.py PRE-CREATION 
>   src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/130/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130416/3c948401/attachment-0001.html>


More information about the openlmi-devel mailing list