Review Request 187: JobManager sync: [1/5] Synchronize JobManager with storage.

Michal Minar reviewboard at gallagherhome.com
Tue Apr 16 07:34:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/187/#review220
-----------------------------------------------------------

Ship it!


Those were just nitpicks. Otherwise it's OK.

- Michal Minar


On April 12, 2013, 2:13 p.m., Jan Safranek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/187/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 2:13 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Synchronize JobManager with storage.
> 
> JobManager here is older version of the one in openlmi-storage.
> Let's sync it with the storage so I can use it from there.
> 
> The patch includes:
> 
> Fixed job expiration under SFCB.
> Added LMI_StorageJob.JobInParameters and .JobOutParameters properties.
> Allow python to exit the provider even if there are threads running.
> Fixed job returning an error
> Added possibility to set AffectedElements when a job finishes.
> Added workaround for rhbz#920763
> 
> 
> Diffs
> -----
> 
>   src/python/openlmi/common/JobManager.py a923f296d3eba40f1997a267b68525a44f50ffc7 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/187/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Safranek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130416/2c9c5e44/attachment.html>


More information about the openlmi-devel mailing list