Review Request 139: [1/10] Add mounting.mof.

Jan Synacek reviewboard at gallagherhome.com
Mon Apr 15 13:09:48 UTC 2013



> On April 9, 2013, 8:44 a.m., Radek Novacek wrote:
> > mof/mounting.mof, line 107
> > <http://reviewboard-openlmi.rhcloud.com/r/139/diff/1/?file=746#file746line107>
> >
> >     Shouldn't this be "Corresponds to 'user' mount option" ?

Yes, this is fixed in [3/10] part of the series.


> On April 9, 2013, 8:44 a.m., Radek Novacek wrote:
> > mof/mounting.mof, line 152
> > <http://reviewboard-openlmi.rhcloud.com/r/139/diff/1/?file=746#file746line152>
> >
> >     an -> a

I'm pretty sure 'an' is correct here. Try pronouncing 'L' (pronounciation begins with a vowel).


> On April 9, 2013, 8:44 a.m., Radek Novacek wrote:
> > mof/mounting.mof, line 212
> > <http://reviewboard-openlmi.rhcloud.com/r/139/diff/1/?file=746#file746line212>
> >
> >     "If binding a local filesystem" - shouldn't it be "If mounting a local filesystem"?

Yes, it should be 'mounting'. I'll fix it.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/139/#review120
-----------------------------------------------------------


On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/139/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 3:22 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Add mounting.mof.
> 
> 
> Diffs
> -----
> 
>   mof/mounting.mof PRE-CREATION 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130415/c5aaf63a/attachment-0001.html>


More information about the openlmi-devel mailing list