Review Request 190: JobManager sync: [4/5] Removed logging from indication sender thread.
Michal Minar
reviewboard at gallagherhome.com
Mon Apr 15 11:29:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/190/#review209
-----------------------------------------------------------
Ship it!
Good catch.
- Michal Minar
On April 12, 2013, 2:14 p.m., Jan Safranek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/190/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 2:14 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> Removed logging from indication sender thread.
>
> When the method starts, the indication thread is not yet registered at
> CIMOM, that's done inside the method using AttachThread(). Therefore
> we should not log anything.
>
>
> Diffs
> -----
>
> src/python/openlmi/common/IndicationManager.py dbe25f397186aba301c3a6c432084b88cecb3dc5
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/190/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Safranek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130415/bb521190/attachment-0001.html>
More information about the openlmi-devel
mailing list