Review Request 193: Don't reload devices from udev on deletion.

Radek Novacek reviewboard at gallagherhome.com
Mon Apr 15 08:51:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/193/#review206
-----------------------------------------------------------

Ship it!



src/openlmi/storage/util/storage.py
<http://reviewboard-openlmi.rhcloud.com/r/193/#comment118>

    You can pass a tuple of classes as second argument of isinstance:
    
    isinstance(action, (blivet.deviceaction.ActionDestroyFormat, blivet.deviceaction.ActionDestroyDevice))
    
    Not an issue, IMHO improves readability a little.


- Radek Novacek


On April 12, 2013, 4:17 p.m., Jan Safranek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/193/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 4:17 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Don't reload devices from udev on deletion.
> 
> If a device or device format is being destroyed, we don't need to reset
> blivet and reload devices from system.
> 
> This should speed up the provider a bit.
> 
> 
> Diffs
> -----
> 
>   src/openlmi/storage/util/storage.py 35cbfb15da3cae2bde1ddca4236452ccfdc7b1b8 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/193/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Safranek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130415/2261e827/attachment.html>


More information about the openlmi-devel mailing list