Review Request 180: openlmi-networking coverity [1/5] Don't use tmpfile, use mkstemp instead

Radek Novacek reviewboard at gallagherhome.com
Thu Apr 11 12:06:56 UTC 2013



> On April 11, 2013, 1:59 p.m., Roman Rakus wrote:
> > Maybe you can be more verbose why you make this change - why is mkstemp() better than tmpfile().

Coverity reports using tmpfile() as insecure. It's not really an issue here, because it's only in tests...

CID 10144 (#1 of 1): Insecure temporary file (SECURE_TEMP)secure_temp: "tmpfile(void)" creates files with predictable names, which is unsafe


- Radek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/180/#review185
-----------------------------------------------------------


On April 11, 2013, 11:07 a.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/180/
> -----------------------------------------------------------
> 
> (Updated April 11, 2013, 11:07 a.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Don't use tmpfile, use mkstemp instead
> 
> 
> Diffs
> -----
> 
>   src/unittest/test_network.c 04a2b44d42164ce79559c32846ccecedb9c94e64 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/180/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130411/1a331312/attachment.html>


More information about the openlmi-devel mailing list