Review Request 144: Fixed job expiration under SFCB.
Roman Rakus
reviewboard at gallagherhome.com
Wed Apr 10 10:52:03 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/144/#review155
-----------------------------------------------------------
Ship it!
It's strange. Push it, but the best would be to ask SFCB upstream and possibly fix it.
- Roman Rakus
On April 8, 2013, 2:07 p.m., Jan Safranek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/144/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 2:07 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-storage
>
>
> Description
> -------
>
> Fixed job expiration under SFCB.
>
> SFCB does not allow logging in not-registered threads, therefore
> we must not log in job's Timer thread, i.e. Job._expire method.
>
> Jobs now expire silently, without any logging, I have bad feelings about it.
>
>
> Diffs
> -----
>
> src/openlmi/storage/JobManager.py e182c16e98a51d0fad3e032895d1103cf333ff64
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/144/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Safranek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130410/7d50810e/attachment-0001.html>
More information about the openlmi-devel
mailing list