Review Request 151: Hardware: Code clean up

Radek Novacek reviewboard at gallagherhome.com
Wed Apr 10 07:09:05 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/151/#review142
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On April 8, 2013, 8:35 p.m., Peter Schiffer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/151/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 8:35 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Hardware: Code clean up
> 
>  * Got rid of asprintf() where suitable (used static memory instead)
>  * Removed if condition before free()
>  * Replaced more hard coded numbers with LMI constants
> 
> 
> Diffs
> -----
> 
>   src/hardware/LMI_ProcessorCacheMemoryProvider.c d4c73f65bee82e26b8b09a9f5ed3bc22945d762a 
>   src/hardware/LMI_Hardware.h 16bdf122e2f5b611b45c7a508726b3a09808c8d4 
>   src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c b06aa223d4e954d51abf2431c3a0a6247283b648 
>   src/hardware/LMI_ProcessorCapabilitiesProvider.c c7c4ff250d89e2c115cbbda8a54845213fccb770 
>   src/hardware/LMI_ProcessorElementCapabilitiesProvider.c ee9cf18a33f2ebe3784b8e5c53c6e28769b1871f 
>   src/hardware/LMI_ProcessorProvider.c 6280bbd60d732433870ebc539146006daf2fa126 
>   src/hardware/cpuinfo.c d80e1cb5890cd1c72fff7c257cb4f042dd50b06d 
>   src/hardware/dmidecode.c a50aa8a19ae0fc3acc6979484cdff2dc1cdff0a9 
>   src/hardware/lscpu.c d4546cb42a401c4b6d79bc9e13990d94c463d282 
>   src/hardware/sysfs.c c2cc1affeabf0329ca32e1d9956eaf468b0a56d1 
>   src/hardware/utils.h 9f5686faf4e50775b18adb62bfd0f5a707f093cb 
>   src/hardware/utils.c da7bbfadffd77afd5ecc1c81360cb7f23f3412e1 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/151/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter Schiffer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130410/0bdad434/attachment.html>


More information about the openlmi-devel mailing list