Review Request 138: [10/10] Add LMI_AttachedFileSystem.

Jan Safranek reviewboard at gallagherhome.com
Tue Apr 9 15:19:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/138/#review139
-----------------------------------------------------------



src/openlmi/storage/LMI_AttachedFileSystem.py
<http://reviewboard-openlmi.rhcloud.com/r/138/#comment96>

    Use:
    provider = self.provider_manager.get_provider_for_format_name
    (device, fmt) = provider.get_format_for_name()



src/openlmi/storage/LMI_AttachedFileSystem.py
<http://reviewboard-openlmi.rhcloud.com/r/138/#comment97>

    d.path != spec is not that easy these days.
    
    There can be various 'devicespecs' in /etc/fstab instead of device name, e.g. 'LABEL=xyz' or 'UUID=abc'. Also, alternative device names can be used (/dev/disk/by-id/uvw).
    
    Keep it in mind for fstab handling.



src/openlmi/storage/LMI_AttachedFileSystem.py
<http://reviewboard-openlmi.rhcloud.com/r/138/#comment98>

    again, use provider_manager && FormatProvider



src/openlmi/storage/LMI_AttachedFileSystem.py
<http://reviewboard-openlmi.rhcloud.com/r/138/#comment99>

    These lines should be removed, we use cimom_entry.py as the entry point from CIMOM


- Jan Safranek


On April 8, 2013, 3:23 p.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/138/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 3:23 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Add LMI_AttachedFileSystem.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 
>   src/openlmi/storage/LMI_AttachedFileSystem.py PRE-CREATION 
>   src/openlmi/storage/MountingProvider.py PRE-CREATION 
>   src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130409/89cfb57c/attachment.html>


More information about the openlmi-devel mailing list