Review Request 136: [8/10] Add LMI_MountPoint.

Jan Safranek reviewboard at gallagherhome.com
Tue Apr 9 15:13:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/136/#review138
-----------------------------------------------------------



src/openlmi/storage/LMI_MountPoint.py
<http://reviewboard-openlmi.rhcloud.com/r/136/#comment93>

    There is no FileSystemType property in LMI_MountPoint.



src/openlmi/storage/LMI_MountPoint.py
<http://reviewboard-openlmi.rhcloud.com/r/136/#comment94>

    This can be retrieved using
    provider = self.provider_manager.get_provider_for_format(device, fmt)
    # throw error if provider is None
    format_name = provider.get_name_for_format(device, fmt) 
    
    Question is how to get fmt and device - device is Blivet StorageDevice and fmt is device.format.



src/openlmi/storage/LMI_MountPoint.py
<http://reviewboard-openlmi.rhcloud.com/r/136/#comment95>

    These lines should be removed, we use cimom_entry.py as the entry point from CIMOM


- Jan Safranek


On April 8, 2013, 3:23 p.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/136/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 3:23 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Add LMI_MountPoint.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 
>   src/openlmi/storage/LMI_MountPoint.py PRE-CREATION 
>   src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/136/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130409/0ad54f32/attachment-0001.html>


More information about the openlmi-devel mailing list