Review Request 139: [1/10] Add mounting.mof.

Jan Safranek reviewboard at gallagherhome.com
Tue Apr 9 14:07:31 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/139/#review134
-----------------------------------------------------------



mof/mounting.mof
<http://reviewboard-openlmi.rhcloud.com/r/139/#comment79>

    why don't we have 'bind' filesystem type for bind mounts? I am sure we talked about it, i don't remember the reason... NULL looks weird here.



mof/mounting.mof
<http://reviewboard-openlmi.rhcloud.com/r/139/#comment80>

    1) I miss some note that IsNext and IsCurrent are properties of LMI_MountedFileSystemElementSettingData, which will be created.
    
    2) I would also emphasize what these IsNext and IsCurrent properties actually mean, e.g.:
    Mode 1 - IsNext = 1, IsCurrent = 1: The filesystem will be mounted and also stored in /etc/fstab.
    (applies to ModifyMount/DeleteMount too)



mof/mounting.mof
<http://reviewboard-openlmi.rhcloud.com/r/139/#comment81>

    IMHO the list of modes can be shortened, e.g. Mode1 does not apply to DeleteMount.



mof/mounting.mof
<http://reviewboard-openlmi.rhcloud.com/r/139/#comment82>

    You can use
    - LMI_MountedFileSystem instead of CIM_ManagedElement
    - correct subclass instead of CIM_Capabilities and CIM_SettingData


- Jan Safranek


On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/139/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 3:22 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-storage
> 
> 
> Description
> -------
> 
> Add mounting.mof.
> 
> 
> Diffs
> -----
> 
>   mof/mounting.mof PRE-CREATION 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Synacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130409/fc5229e8/attachment-0001.html>


More information about the openlmi-devel mailing list