Review Request 148: openlmi-networking [1/3] Rework setting creation

Jan Safranek reviewboard at gallagherhome.com
Tue Apr 9 07:33:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/148/#review121
-----------------------------------------------------------


The whole concept of creating and modifying settings using a method seems weird to me.

Looking into DSP 1116 1.0.0, it's not explicitly written anywhere (or I haven't found it), but from chapter "9.5 Determine supported settings", it seems to me that a CIM_IPNetworkConnection already must have all supported CIM_IPAssignmentSettingData associated and there is no need to create the setting using our proprietary CreateOrModifyStaticSetting.


- Jan Safranek


On April 8, 2013, 4:53 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/148/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 4:53 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Rework setting creation methods
> 
> Methods CreateStaticSetting, CreateDHCPSetting and CreateSlaveSetting was
> renamed to CreateOrModifyStaticSetting, CreateOrModifyDynamicSetting and
> CreateOrModifySlaveSetting.
> 
> All of them now can be used to modify existing setting when SettingData
> input argument is supplied.
> 
> CreateOrModifyStaticSetting now supports multiple IP addresses,
> netmasks/prefixes and gateways -- it's more aligned with
> ExtendedStaticIPAssignmentSettingData class.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Networking.mof fb9580105931ba03d1895279d9af561a0e5c5b46 
>   src/LMI_IPAssignmentSettingDataProvider.c c3b632c49378233432945cbb8bd3f215425b96ae 
>   src/LMI_IPConfigurationServiceProvider.c 14af9e65aa0948955a551ac1edce1f5262a28588 
>   src/connection.h 668460a76d97e0195e53804c29f631b095df2782 
>   src/connection.c 7678cab5785e6b95edef103dbf3a3fa5f0612efd 
>   src/connection_nm.c a0b92223c0bc1a18a29d7bf3342cf5423c835c7f 
>   src/setting.h 514e7f0469085e73d3293a060752a0193816d9fd 
>   src/setting.c 25fa7cbad6e8d52359d0142c7210fa8e6a9d5d71 
>   test/test_apply_connection.py 887cf7825a316ffc437eae650cb55afff02c7b0d 
>   test/test_create_destroy_connection.py b278d6acfbb509a8398926f3d6106a92adbe1dcc 
>   test/test_enable_disable_iface.py 792d3ade8a854ecea38b70ac7d73e157f59f0e53 
>   test/test_modify_connection.py PRE-CREATION 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130409/24125d1c/attachment.html>


More information about the openlmi-devel mailing list