[netcf-devel] [PATCH 1/5] don't redefine DATADIR

Eric Blake eblake at redhat.com
Tue Mar 17 22:48:03 UTC 2015


On 03/16/2015 09:03 AM, Laine Stump wrote:

> 
> To eliminate the warnings, all we need to do is remove the pointless
> 

As you already pointed out, I'm sure you'll complete this thought before
pushing.

> This does point out that our Makefile rule to generate datadir.h is
> essentially open-coding the same thing that can now be accomplished by
> looking at DATADIR in gnulib configmake.h. (and that, in turn, points
> out that the win32 port very likely no longer compiles, due to the
> conflict between DATADIR in configmake.h and the DATADIR in the win32
> headers. Since the win32 port was never finished, this isn't a big
> issue though.) That is a mess to clean up another day...

Yeah, volunteers welcome on that front.

> ---
>  src/internal.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <https://lists.fedorahosted.org/pipermail/netcf-devel/attachments/20150317/6bf8adb6/attachment.sig>


More information about the netcf-devel mailing list