[netcf-devel] [PATCH] Remove extraneous single quotes from IPV6ADDR_SECONDARIES

Laine Stump laine at laine.org
Sat Mar 7 08:04:04 UTC 2015


On 12/05/2014 01:26 AM, Jianwei Hu wrote:
> The IPV6ADDR_SECONDARIES setting in ifcfg files was being set
> with an extra set of single quotes.
>
> For example:
> After defining a interface with multi-ipv6 addresses
> [root at localhost ~]# cat /etc/sysconfig/network-scripts/ifcfg-enp2s0
> DEVICE=enp2s0
> ONBOOT=yes
> IPV6INIT=yes
> IPV6_AUTOCONF=no
> DHCPV6C=no
> IPV6ADDR=2002::200/64
> IPV6ADDR_SECONDARIES="'2002::201/64 2002::202/64'"
>
> Should like below:
> [root at localhost ~]# cat /etc/sysconfig/network-scripts/ifcfg-enp2s0
> DEVICE=enp2s0
> ONBOOT=yes
> IPV6INIT=yes
> IPV6_AUTOCONF=no
> DHCPV6C=no
> IPV6ADDR=2002::200/64
> IPV6ADDR_SECONDARIES="2002::201/64 2002::202/64"
>
> Since the extra quotes are added in all cases, this patch just
> unconditionally removes them.
> ---
>  data/xml/redhat-get.xsl                   | 2 --
>  data/xml/suse-get.xsl                     | 2 --
>  tests/redhat/schema/ipv6-static-multi.xml | 2 +-
>  tests/suse/schema/ipv6-static-multi.xml   | 2 +-
>  4 files changed, 2 insertions(+), 6 deletions(-)

Sorry, I somehow forgot about this patch until the BZ came back on my
radar. This solves the problem in exactly the same manner as commit
581ff3f fixed it for BONDING_OPTS. I made a couple very slight changes
to the wording of the commit message, added a reference to the BZ, and
pushed.

Thanks for the contribution!



More information about the netcf-devel mailing list