[netcf-devel] [PATCH] eliminate netcf-specific sysconfig.aug lense

Eric Blake eblake at redhat.com
Mon Mar 2 17:51:08 UTC 2015


On 02/27/2015 09:09 PM, Laine Stump wrote:
> Back in 2010 when netcf needed a separate augeas lense for files in

s/lense/lens/ here and in the subject.

> sysconfig/network-scripts (e.g. the ifcfg-* files), augeas itself had
> no special purpose sysconfig.aug lense, so netcf has its own
> sysconfig.aug lens based on the shellvars.aug lense from augeas at the
> time. Sometime soon after that augeas got its own sysconfig.aug lense,
> but netcf never rid itself of its own copy.

and 3 more instances; but at least you got one right!

> 
> The sysconfig.aug in netcf is now severely out of date compared to the
> one in augeas, and is missing many bugfixes. This patch just removes
> the netcf version from /usr/share/netcf/lenses, so that augeas will
> use its own lense when it's called by netcf. Among other things, this
> updated lense properly ignores semicolons and "#"-initiated partial

Two more.

> line comments at the ends of lines that contain valid variable
> settings at the beginning.
> 
> This resolves:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=761246
> ---
>  Makefile.am               |  1 -
>  data/lenses/sysconfig.aug | 60 -----------------------------------------------
>  2 files changed, 61 deletions(-)
>  delete mode 100644 data/lenses/sysconfig.aug

ACK

Does this mean a spec file for a Fedora build now needs to call out a
minimum augeas version, or are we okay in that all supported Fedora
builds (F20 and later) already have it?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <https://lists.fedorahosted.org/pipermail/netcf-devel/attachments/20150302/f7d243e5/attachment.sig>


More information about the netcf-devel mailing list