[netcf-devel] [PATCH v2] Report file path and reason when aug_save fails

Dominic Cleal dcleal at redhat.com
Fri Sep 5 08:23:07 UTC 2014


On 05/09/14 09:21, Dominic Cleal wrote:
> When aug_save fails, the /augeas metadata tree is now searched to find a
> possible reason for the failure and an error is raised containing the file
> path, Augeas error code (pointing to the action that failed) and the message if
> supplied (from strerror).
> 
> A failure to unlink a file now results in a message such as:
> 
>   error: unspecified error
>   error: aug_save failed on /etc/sysconfig/network-scripts/ifcfg-em1:
>   unlink_orig (Permission denied)
> 
> Multiple failures aren't reported in detail, but will be printed if debug is
> enabled.
> ---
>  src/drv_debian.c  | 21 ++++-----------------
>  src/drv_redhat.c  | 21 ++++-----------------
>  src/drv_suse.c    | 21 ++++-----------------
>  src/dutil_linux.c | 40 ++++++++++++++++++++++++++++++++++++++++
>  src/dutil_linux.h |  3 +++
>  5 files changed, 55 insertions(+), 51 deletions(-)

This updated patch fixes some compilation errors and warnings in
drv_{debian,suse}.c that I'd missed.

-- 
Dominic Cleal
Red Hat Engineering


More information about the netcf-devel mailing list