[netcf-devel] [PATCH] netcf return a clear error message from netcf-transaction.sh

Laine Stump laine at laine.org
Mon Jul 28 17:52:02 UTC 2014


On 07/28/2014 12:28 PM, Eric Blake wrote:
> On 06/22/2014 09:05 PM, Jianwei Hu wrote:
>> netcf need return a detail message when change-begin/change-commit/change-rollback failed.
>> I think netcf had better print the returned messages from netcf-transaction.sh into netcf's error directly.
>>
>> for example:
>>
>> [root at rhel6 ~]# virsh iface-begin
>> error: Failed to begin network config change transaction
>> error: Requested operation is not valid: failed to begin transaction:
>> Operation invalid in this state - Running '/usr/libexec/netcf-transaction.sh change-begin'
>> operation is invalid in this state: There is already an open transaction (/var/lib/netcf/network-snapshot exists)
>> ---
>>  src/dutil_posix.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> ACK from my point of view, but I'll let Laine chime in (he may have been
> offline when this first came to the list)

Thanks for noticing this, Eric! I must have clicked past my netcf folder
and this message was marked as read without me actually reading it, so I
never actually saw it.

Yes, this looks good to me too. I just pushed it upstream. Thanks for
the contribution Jianwei!


More information about the netcf-devel mailing list