[netcf-devel] [PATCH 2/2] maint: use gnulib's configmake instead of hard-coded names

Eric Blake eblake at redhat.com
Thu Jan 30 15:55:27 UTC 2014


On 01/30/2014 07:08 AM, Laine Stump wrote:
> On 01/24/2014 01:08 AM, Eric Blake wrote:
>> Resolve a FIXME from an earlier commit; rather than hard-coding

I tweaked this to call out commit 2ca7857c.

>> use of /usr/libexec, we should be installing/using files relative
>> to the ${libexecdir} location chosen during configure.
>>
>>
>> +#undef NETCF_TRANSACTION
>>  #define NETCF_TRANSACTION "/bin/false"
>> +#endif
> 
> Oops. Got an extra #endif in there :-)

Which means I obviously didn't test on a debian system :)  I think I had
an '#ifndef NETCF_TRANSACTION' in an earlier version of the patch,
before realizing config.h unconditionally defines NETCF_TRANSACTION.

> 
> ACK with that fixed.

Fixed and series pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <https://lists.fedorahosted.org/pipermail/netcf-devel/attachments/20140130/436ed18c/attachment.sig>


More information about the netcf-devel mailing list