[netcf-devel] [PATCH] Require bridge-utils for netcf-libs in the specfile

Daniel P. Berrange berrange at redhat.com
Fri Feb 7 14:27:12 UTC 2014


On Fri, Feb 07, 2014 at 04:24:39PM +0200, Laine Stump wrote:
> This resolves:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=911403 (Fedora 20)
>   https://bugzilla.redhat.com/show_bug.cgi?id=1060317 (RHEL7)
> 
> netcf itself doesn't use anything in bridge-utils, but it called
> /sbin/ifup, which *can* run brctl (which is part of bridge-utils).
> Technically, initscripts should require brutils (since /sbin/ifup is a
> part of initscripts), but we all know that's not going to
> happen. Instead we can just make netcf require bridge-utils. It's not
> a very large package, so it's unlikely we'll get any complaints about
> bloat.
> 
> (NB: in the past, libvirt had a Requires: bridge-utils, so this didn't
> used to be a problem. libvirt removed this Requires: in v0.9.8, when
> it switched from execing brctl to directly calling ioctls to create
> and manage bridge devices.)
> ---
>  netcf.spec.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/netcf.spec.in b/netcf.spec.in
> index 5979bd4..7b74f72 100644
> --- a/netcf.spec.in
> +++ b/netcf.spec.in
> @@ -78,6 +78,10 @@ developing applications that use %{name}.
>  Summary:        Libraries for %{name}
>  Group:          System Environment/Libraries
>  
> +# bridge-utils is needed because /sbin/ifup calls brctl
> +# if you create a bridge device
> +Requires:       bridge-utils
> +
>  %description    libs
>  The libraries for %{name}.

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


More information about the netcf-devel mailing list