[netcf-devel] [PATCH] remove extraneous quotes from BONDING_OPTS

Eric Blake eblake at redhat.com
Wed Jul 3 17:47:17 UTC 2013


On 07/03/2013 11:37 AM, Laine Stump wrote:
> From: Satoru SATOH <ssato at redhat.com>
> 
> For some unknown reason, the BONDING_OPTS setting in ifcfg files was
> being set with an extra set of single quotes. So, for example, instead of:
> 
>   BONDING_OPTS="mode=active-backup primary=eth1 miimon=100 updelay=10 use_carrier=0"
> 
> we would get (e.g.):
> 
>   BONDING_OPTS="'mode=active-backup primary=eth1 miimon=100 updelay=10 use_carrier=0'"
> 
> Even when there weren't any BONDING_OPTS to set, the ifcfg file would
> still get:
> 
>   BONDING_OPTS="''"
> 
> Since the extra quotes are added in all cases, and are never needed,
> this patch just unconditionally removes them.

ACK.

> +++ b/AUTHORS
> @@ -19,4 +19,5 @@ Contributions by:
>    Guido Günther    <agx at sigxcpu.org>
>    Ed Maste         <emaste at freebsd.org>
>    Hendrik Schwartke <hendrik at os-t.de>
> -  Ting Liu         <b28495 at freescale.com>
> \ No newline at end of file

And nice that you are fixing this in the process.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <https://lists.fedorahosted.org/pipermail/netcf-devel/attachments/20130703/6c2c0568/attachment.sig>


More information about the netcf-devel mailing list