[netcf-devel] fix mistyped PATH_SEPARATOR in configure.ac

Laine Stump laine at laine.org
Mon Jul 23 18:20:53 UTC 2012


On 07/23/2012 01:22 PM, Serge Hallyn wrote:
> Otherwise configure doesn't find /sbin/ifdown (by default) on debian.
>
> Signed-off-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

ACK and pushed. However, for future reference:

1) This wasn't created using git send-email or git format-patch, so it
didn't apply cleanly.

2) the file "configure" is a generated file, so shouldn't be included in
patches.

Since it's a trivial patch, I recreated it manually.

> ---
>  netcf-0.2.0/configure.ac |    4 ++--
>  netcf-0.2.0/configure    |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> Index: netcf-0.2.0/configure.ac
> ===================================================================
> --- netcf-0.2.0.orig/configure.ac	2012-07-20 19:58:29.000000000 +0000
> +++ netcf-0.2.0/configure.ac	2012-07-23 16:58:10.000000000 +0000
> @@ -143,13 +143,13 @@
>  
>  if test "x$with_driver" = "xdebian"; then
>  	dnl Check for ifup and ifdown in debian
> -	AC_PATH_PROG(IFDOWN, ifdown, false, $PATH$PATHSEPARATOR/sbin)
> +	AC_PATH_PROG(IFDOWN, ifdown, false, $PATH$PATH_SEPARATOR/sbin)
>  	if test "$IFDOWN" = "false"; then
>  	   AC_MSG_ERROR([ifdown not found])
>  	fi
>  	AC_DEFINE_UNQUOTED([IFDOWN], "$IFDOWN", [path to ifdown binary])
>  
> -	AC_PATH_PROG(IFUP, ifup, false, $PATH$PATHSEPARATOR/sbin)
> +	AC_PATH_PROG(IFUP, ifup, false, $PATH$PATH_SEPARATOR/sbin)
>  	if test "$IFUP" = "false"; then
>  	   AC_MSG_ERROR([ifup not found])
>  	fi
> Index: netcf-0.2.0/configure
> ===================================================================
> --- netcf-0.2.0.orig/configure	2012-07-20 20:00:48.000000000 +0000
> +++ netcf-0.2.0/configure	2012-07-23 17:04:23.000000000 +0000
> @@ -28368,7 +28368,7 @@
>    ;;
>    *)
>    as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
> -for as_dir in $PATH$PATHSEPARATOR/sbin
> +for as_dir in $PATH$PATH_SEPARATOR/sbin
>  do
>    IFS=$as_save_IFS
>    test -z "$as_dir" && as_dir=.
> @@ -28418,7 +28418,7 @@
>    ;;
>    *)
>    as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
> -for as_dir in $PATH$PATHSEPARATOR/sbin
> +for as_dir in $PATH$PATH_SEPARATOR/sbin
>  do
>    IFS=$as_save_IFS
>    test -z "$as_dir" && as_dir=.
> _______________________________________________
> netcf-devel mailing list
> netcf-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/netcf-devel



More information about the netcf-devel mailing list