[netcf-devel] [PATCH 3/5] Do not exit on fail for pkg-config check for Windows

Laine Stump laine at laine.org
Thu Sep 23 15:10:12 UTC 2010


  On 09/22/2010 04:00 PM, Eric Blake wrote:
> On 09/17/2010 10:28 AM, Adam Stokes wrote:
>> ---
>>    configure.ac |    4 ++--
>>    1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 185d3f8..e0a10b3 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -43,11 +43,11 @@ NETCF_COMPILE_WARNINGS
>>
>>    dnl Need to test if pkg-config exists
>>    PKG_PROG_PKG_CONFIG
>> -PKG_CHECK_MODULES([LIBAUGEAS], [augeas>= 0.5.0])
>> +PKG_CHECK_MODULES([LIBAUGEAS], [augeas>= 0.5.0], [], [AC_DEFINE([HAVE_LIBAUGEAS], [], [Use augeas])])
>>    PKG_CHECK_MODULES([LIBXML], [libxml-2.0])
>>    PKG_CHECK_MODULES([LIBXSLT], [libxslt])
>>    PKG_CHECK_MODULES([LIBEXSLT], [libexslt])
>> -PKG_CHECK_MODULES([LIBNL], [libnl-1])
>> +PKG_CHECK_MODULES([LIBNL], [libnl-1], [], [AC_DEFINE([HAVE_LIBNL], [], [Use netlink])])
> ACK.  In fact, this could probably be pushed now, as it is independent
> of the rest of your patches, even though the rest of the code is not yet
> using HAVE_LIBAUGEAS or HAVE_LIBNL.
>

What will happen on a Linux system that doesn't have augeas-devel and 
libnl-devel? Will it obscure the current specific error report 
("augeas-devel is required to build" or whatever it says) with something 
more difficult to figure out? (Dunno, haven't tried. Just wondering.). 
Since these packages are never used on Windows, but are required on 
Linux, is there a simple way to require them on one, but not even check 
for them on the other?



More information about the netcf-devel mailing list