[netcf-devel] [PATCH 5/5] Conditionalize Windows portion

Eric Blake eblake at redhat.com
Thu Sep 23 12:00:57 UTC 2010


On 09/22/2010 02:17 PM, Eric Blake wrote:
>> +++ b/src/ncftool.c
>> @@ -677,7 +677,11 @@ static void parse_opts(int argc, char **argv) {
>>        while ((opt = getopt_long(argc, argv, "+dhr:", options,&idx)) != -1) {
>>            switch(opt) {
>>            case 'd':
>> +#ifdef WIN32
>> +            _putenv("NETCF_DEBUG=1");
>> +#else
>>                setenv("NETCF_DEBUG", "1", 1);
>> +#endif
>
> NACK to this hunk; I'd rather get gnulib to relax the 'setenv' module to
> LGPLv2+ and rely on that (I've just sent an email to the gnulib list
> requesting that).

Gnulib setenv is not LGPLv2+, so let's use it.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


More information about the netcf-devel mailing list