[netcf-devel] [PATCH] remove duplicate routines

Eric Blake eblake at redhat.com
Fri Sep 17 15:03:06 UTC 2010


On 09/17/2010 08:54 AM, Adam Stokes wrote:
> ---
>   src/netcf_win.c |   14 +-------------
>   src/netcf_win.h |    2 --
>   2 files changed, 1 insertions(+), 15 deletions(-)
>
> diff --git a/src/netcf_win.c b/src/netcf_win.c
> index 166465e..e443614 100644
> --- a/src/netcf_win.c
> +++ b/src/netcf_win.c
> @@ -13,7 +13,7 @@ PMIB_IPADDRTABLE _get_ip_addr_table(PMIB_IPADDRTABLE ipAddrTable) {
>       DWORD r = 0;
>       DWORD buf = 0;
>
> -    ipAddrTable = (PMIB_IPADDRTABLE) sizeof (MIB_IPADDRTABLE);
> +    ipAddrTable = (PMIB_IPADDRTABLE) malloc(sizeof (MIB_IPADDRTABLE));

Hmm, this hunk is unrelated to the subject, and exists to undo the botch 
in the 1/2 patch series that I already commented on.  But 
src/netcf_win.c doesn't even exist yet, which technically means this 
should be part of the series that adds it, or even better rebased so 
that we never see the addition of duplicate code in the first place.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


More information about the netcf-devel mailing list