[netcf-devel] [PATCH] Rename driver backend to not be so generic
Laine Stump
laine at laine.org
Mon Nov 15 21:47:01 UTC 2010
On 11/15/2010 12:41 PM, Adam Stokes wrote:
> Rename drv_initscripts driver backend to indicate this being a Linux only set of routines.
> ---
> src/Makefile.am | 2 +-
> src/drv_initscripts.c | 1097 -------------------------------------------------
> src/drv_linux.c | 1097 +++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 1098 insertions(+), 1098 deletions(-)
> delete mode 100644 src/drv_initscripts.c
> create mode 100644 src/drv_linux.c
Actually, drv_initscripts.c is more specific (and more correct) than
drv_linux.c. That file will only work on those linux platforms that use
individual ifcfg-* files (powered by initscripts) to configure their
interfaces. This includes Fedora, RHEL, and SuSE, and (m)any derivatives
of them (it will require some modifications to work on SuSE, but
somebody has done that and is working on patches to submit).
Many other Linux platforms will *not* work with drv_initscripts, eg
debian, ubuntu, gentoo - they use a single config file in a completely
different format.
In the meantime, after reviewing your patches last week, I noticed there
are some functions in "suboptimal" places that should be moved around
(eg, the unix run_program function is in netcf.c, which really should be
platform-independent). Last week I had a quick go at moving things
around to be better organized along platform lines, but had to take a
break and go back to some libvirt work. I'll try and go back to that
this week, as it may simplify your work.
More information about the netcf-devel
mailing list