[netcf-devel] [PATCH] rng: Don't fail validation if child interfaces have extraneous info

Cole Robinson crobinso at redhat.com
Mon Jun 28 15:57:58 UTC 2010


On 06/27/2010 11:16 PM, Laine Stump wrote:
>   On 06/14/2010 05:25 PM, Cole Robinson wrote:
>> Currently, child interfaces for bonds and bridges are expected to be
>> specified in a slimmed down 'bare' style, only supplying the required
>> information like name, MAC, etc. This makes the lives of API users
>> difficult for a couple reasons:
>>
>> 1) The existing interface XML can not be reused wholesale as a child
>>     interface, it must be processed to remove unneeded information (which
>>     netcf already does during the XSL transform).
>>
>> 2) Any future changes to the allowed values in the 'bare' definition will
>>     require applications to be updated.
>>
>> This patch changes the RNG to optionally accept unneeded interface
>> XML for child interfaces, and a few test files to validate the changes.
>> XSL stylesheets seem to already handle the hard work for us of ignoring
>> the pieces it does not need.
> 
> Now that I've finally gotten the time to check this, I've found that 
> libvirt actually already strips out the extraneous stuff in the 
> definition, so this patch is not needed for the purposes of libvirt and 
> virt-manager (the miimon/arpmon patch you had sent along with this one 
> seems to make everything work for me)..
> 

Cool, if that's all it takes, I'm fine with dropping this patch.

Thanks,
Cole



More information about the netcf-devel mailing list