[netcf-devel] [PATCH] Report actual mac address in ncf_if_xml_state.
David Lutterkort
lutter at redhat.com
Mon Oct 26 10:36:50 UTC 2009
On Fri, 2009-10-23 at 13:32 -0400, Laine Stump wrote:
> Iterate the NETLINK link cache to find the entry for each interface,
> extract the mac address, and add it to the XML.
This doesn't apply for me, neither on top of the ncf_if_status patch,
nor on master. I get
Applying: Report actual mac address in ncf_if_xml_state.
error: patch failed: src/dutil.c:735
error: src/dutil.c: patch does not apply
Patch failed at 0001 Report actual mac address in
ncf_if_xml_state.
> ---
> src/dutil.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 66 insertions(+), 1 deletions(-)
>
> diff --git a/src/dutil.c b/src/dutil.c
> index 1fc6097..a010d27 100644
> --- a/src/dutil.c
> +++ b/src/dutil.c
> @@ -708,10 +709,60 @@ error:
> return;
> }
>
> +static void _add_mac_cb(struct nl_object *obj, void *arg) {
No need to start names with '_'. Just call it 'add_mac_cb'.
> + nl_addr2str(addr, mac_str, sizeof(mac_str));
Ugh .. no way to check that the buffer was big enough - I filed BZ
530969 for that.
David
More information about the netcf-devel
mailing list