[netcf-devel] [PATCH 3/3] Remove newly deprecated code.

Laine Stump laine at laine.org
Thu Oct 22 17:19:44 UTC 2009


On 10/22/2009 12:53 PM, David Lutterkort wrote:
> On Thu, 2009-10-22 at 09:43 -0400, Laine Stump wrote:
>    
>> This patch removes add_ipv4_state_to_xml_doc() (which uses
>> ioctl(SIOCGIFADDR)), whose functionality was replaced in the previous
>> commit with the new add_state_to_xml_doc() (which uses the netlink
>> socket).
>> ---
>>   src/dutil.c |   79 -----------------------------------------------------------
>>   src/dutil.h |    3 --
>>   2 files changed, 0 insertions(+), 82 deletions(-)
>>      
> Looks good. Shouldn't if_ipv4_{address,netmask,prefix} go, too ?
>    

Well, it is quite a bit more involved to get an IP address using 
netlink, and someone in the future might want to get a single address 
per interface for some kind of naming or indexing or something. But I 
guess if that ever happens, they can just rewrite these functions (and 
do them the right way). I'll modify the patch to remove those too.


More information about the netcf-devel mailing list