[netcf-devel] [PATCH 2/2] Remove all config-origined info from ncf_if_xml_state output.

David Lutterkort lutter at redhat.com
Wed Oct 7 21:31:08 UTC 2009


On Wed, 2009-10-07 at 15:42 -0400, Laine Stump wrote:
> I actually removed that initialization as a pre-emptive move against Jim 
> ever running clang on netcf - ncf_xml is guaranteed to be initialized in 
> every code path, so the initialization in the definition will (from what 
> I understood of the emails about running clang against libvirt) make 
> clang ring its bell (or blow its whistle, or whatever it is that clang 
> does ;-)
> 
> I'm not clang, though, so it's okay with me to leave it in!

Until we use clang as a matter-of-course, I am more comfortable with
redundant initializations, rather than have small code changes break
rarely-exercised code paths.

David




More information about the netcf-devel mailing list