[netcf-devel] Support for VLAN interfaces

Daniel P. Berrange berrange at redhat.com
Tue Jun 30 16:31:48 UTC 2009


On Tue, Jun 30, 2009 at 04:22:15PM +0000, David Lutterkort wrote:
> 
> Sure, I can change it to that. In addition, I want to move the name of
> an interface from a nested <name> element to the name attribute of the
> interface element across the board. That would make your above snippet
> 
>         <interface type="vlan">
>       <vlan tag="42">
>         <interface name='eth0'/>
>       </vlan>
>    </interface>

Ok, that sounds good.

> 
> > This matches the nesting structure used for bridges, and bonding, so
> > making it easier to deal with the XML structure in applications.
> > eg, if you have an interface XML doc you can reliably extract any
> > dependant interface names with an Xpath "/interface/*/interface/name",
> > and not have to special case vlans by checking for an @device attribute
> > instead of nested 'name' element.
> 
> Agreed; of course, the nesting gets a little deeper for a vlan enslaved
> in a bridge since you now have three levels of <interface> elements:

That's no worse than bridge + bond + physical  NIC, so I think its
fine.

> Looking at this, I'd also prefer pulling out the startmode attribute on
> all interface elements into a child element:
> 
>         <interface type='...' name='...'>
>           <start mode='onboot'/>
>           ...
>         </interface>

Agreed, that would allow us more flexibility if we come across some
other attribute we need to track in relation to start mode.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


More information about the netcf-devel mailing list