[netcf-devel] [PATCH 1.5/2] SuSE driver - drv_suse.c

David Lutterkort lutter at redhat.com
Fri Jun 26 23:42:34 UTC 2009


On Fri, 2009-06-26 at 12:44 +0200, Jonas Eriksson wrote:
> These files are heavily based on their initscript-counterpart.
> However, posting a diff would be mostly messy. I therefore post
> the whole files.

Having the diff makes it easier to apply to a git tree (plus, you get to
write your own commit message ;).

> Mailman stopped the mail because it was too large, so i am
> resending the 2nd part of the patch splitted in two.

Strange ... did you try sending it with git-send-email, i.e. as the body
of the email rather than in attachments ?

Assuming you are doing your work on a local 'dev/suse' topic branch off
of master, do the folllowing to send your patch series:

        rm -rf /tmp/suse-patches && mkdir /tmp/suse-patches
        git checkout master
        git pull
        git checkout dev/suse
        git rebase master
        git format-patch -o /tmp/suse-patches -n master
        git send-email --compose --subject 'SuSE driver' --thread /tmp/suse-patches

As for drv_suse.c itself, my main comment is that as much of the code
that is common between drv_initscripts.c and drv_suse.c should be
factored out into one or more utility files. Now that we (well, you,
really ;) know the general direction of where things need to go for SuSE
support, it's probably best to start with those refactoring patches.

David

        



More information about the netcf-devel mailing list