[PATCH] tests: adapt test to accommodate just-changed code

Jim Meyering jim at meyering.net
Mon Mar 12 16:31:43 UTC 2012


Pete Zaitcev wrote:
> On Sat, 10 Mar 2012 11:29:12 +0100
> Jim Meyering <jim at meyering.net> wrote:
>
>> +++ b/t/basic
>>  # Ensure that an attempt to add each reserved attribute fails.
>> +curl -f -X PUT $bucket/rsvd_attr # Create the object we'll use.
>>  for attr in $attr_words; do
>
> Strange, I applied your main patch and tests passed without this.

Hi Pete,

Thanks for testing that.

Odd, indeed that you wouldn't need that patch.
I need it every time, now.

I've just double-checked by reverting that change,

    git show v1.4-6-g86cbea7|patch -R -p1

and running "make -j12 check" as I usually do, and it failed
the "t/basic" test, as before.

I don't see how it could be a race or timing sensitive,
but ran that one test all by itself, just to be sure:

    make check -C t TESTS=basic VERBOSE=yes

and it failed then, too.

In case you want to pursue it, here's the tail of the failed t/basic.log:

  + curl -f -T - http://localhost:9095/b1/rsvd_attr/_bucket
  Mar 12 17:23:03 iwhd[25306]: URI: /b1/rsvd_attr/_bucket
  Mar 12 17:23:03 iwhd[25306]: 127.0.0.1.58342 "PUT /b1/rsvd_attr/_bucket" -
  Mar 12 17:23:03 iwhd[25306]: parse_url: 3: b1 rsvd_attr _bucket
  Mar 12 17:23:03 iwhd[25306]: PROXY PUT ATTR /b1/rsvd_attr/_bucket (0)
  Mar 12 17:23:03 iwhd[25306]: b1/rsvd_attr not found at primary
  Mar 12 17:23:03 iwhd[25306]: 127.0.0.1.58342 404 20
  + grep ' 400$' bad_attr.err
  ++ cat bad_attr.err
  + fail_ 'expected ...400; got this: + env curl -q -s -S -f -T - http://localhost:9095/b1/rsvd_attr/_bucket
  curl: (22) The requested URL returned error: 404'
  + warn_ 'basic: failed test: expected ...400; got this: + env curl -q -s -S -f -T - http://localhost:9095/b1/rsvd_attr/_bucket
  curl: (22) The requested URL returned error: 404'
  + case $IFS in
  + printf '%s\n' 'basic: failed test: expected ...400; got this: + env curl -q -s -S -f -T - http://localhost:9095/b1/rsvd_attr/_bucket
  curl: (22) The requested URL returned error: 404'
  basic: failed test: expected ...400; got this: + env curl -q -s -S -f -T - http://localhost:9095/b1/rsvd_attr/_bucket
  curl: (22) The requested URL returned error: 404
  + test 9 = 2
  + printf '%s\n' 'basic: failed test: expected ...400; got this: + env curl -q -s -S -f -T - http://localhost:9095/b1/rsvd_attr/_bucket
  curl: (22) The requested URL returned error: 404'
  + sed 1q
  + Exit 1


More information about the iwhd-devel mailing list