[PATCH] dc-rhev-image: don't ignore setregid or setreuid failure

Jim Meyering meyering at redhat.com
Tue Aug 21 12:27:41 UTC 2012


* dc-rhev-image.c (copyimage): Don't ignore setregid or setreuid
failure.
---
 dc-rhev-image.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dc-rhev-image.c b/dc-rhev-image.c
index ee2b5d3..66b8461 100644
--- a/dc-rhev-image.c
+++ b/dc-rhev-image.c
@@ -1908,8 +1908,11 @@ static void copyimage(const struct config *cfg, const struct id_pack *idp,

 	if (geteuid() == 0) {
 		/* printf("We're root, changing user and group to 36"); */
-		setregid(-1, NFSGID);
-		setreuid(-1, NFSUID);
+		if (setregid(-1, NFSGID) || setreuid(-1, NFSUID)) {
+			fprintf(stderr, "ERROR Failed to set-IDs to NFS: %s\n",
+				strerror (errno));
+			exit(EXIT_FAILURE);
+		}
 	} else {
 		if (geteuid() != NFSUID || getegid() != NFSGID) {
 			fprintf(stderr,
--
1.7.12


More information about the iwhd-devel mailing list