[patch iwhd 2/3] use uniform port assignment in t/auto

Jim Meyering jim at meyering.net
Fri Oct 7 20:41:26 UTC 2011


Pete Zaitcev wrote:
> Try as I might, I cannot remember a special reason to have fixed port
> assignment in the test "auto".

Good change.

> This was found when I noticed that "FS/" was not pre-created properly.

How odd...  No diagnostic?  I don't see any without your patch.
Not diagnosing something like that sounds like a bug.

I note that you're adding mongod, too.
That's ok, for consistency, even though t/auto does not
use that directory like the other tests do.  Since the
others start mongod manually, they use at least mongod/pid.

ACK.  Thanks.

> ---
>  t/auto |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/auto b/t/auto
> index dee4c4e..c9f18ab 100644
> --- a/t/auto
> +++ b/t/auto
> @@ -3,9 +3,9 @@
>
>  . "${srcdir=.}/init.sh"; path_prepend_ ..
>
> -mkdir iwhd || framework_failure_ mkdir failed
> +mkdir FS mongod iwhd || framework_failure_ mkdir failed
>
> -port=9094
> +port=$(get_port 9095 $lock_dir/i-) || fail_ "failed to get iwhd port"
>  m_port=27018 # auto-start default
>
>  printf '[{"path": "FS", "type": "fs", "name": "primary"}]\n' \


More information about the iwhd-devel mailing list