[patch iwhd 1/1] Add 2-legged OAuth message of "Tue, 4 Oct 2011 19:57:37 -0600")

Jim Meyering jim at meyering.net
Wed Oct 5 20:01:56 UTC 2011


Thanks again for your OAuth-adding work and the patch.
Even though your t/poke.c program is "just" for testing,
I like it a lot and thought it'd be worth spending an hour or so on.
Some of these changes are mostly cosmetic, but even those
improve readability, at least for me.  Anything that reduces
complexity and line-count as much as this series does usually
helps me.  It's not all cosmetic, too...

 b/rest.c        |   12 +++---
 b/t/Makefile.am |   18 +++------
 b/t/oauth       |   13 +++---
 b/t/poke.c      |  106 ++++++++++++++++++++++-------------------------------
 b/user.c        |    9 +---
 t/poke.c        |  110 +++++++++++++++++++++++---------------------------------
 6 files changed, 116 insertions(+), 152 deletions(-)

[PATCH 01/11] use error rather than printf/strerror/exit; const
[PATCH 02/11] t/Makefile.am: Use automake variables rather than
[PATCH 03/11] (do_input, input_one): remove unused parameter
[PATCH 04/11] more const-correctness; ensure that cat never returns
[PATCH 05/11] more s/fprintf+exit+strerror/error/
[PATCH 06/11] * t/poke.c (do_input): Don't ignore write failure.
[PATCH 07/11] save a line; use "sizeof *VAR" rather than
[PATCH 08/11] t/poke: don't ignore write error to stdout; use
[PATCH 09/11] simplify user_add
[PATCH 10/11] t/oauth: prettify
[PATCH 11/11] avoid NULL-deref on OOM

I realize that handling all of these patches may be a pain,
i.e., merging with my other Makefile.am changes (I haven't tried),
but I should be able to add take care of that tomorrow morning.


More information about the iwhd-devel mailing list