Falcon back-end patch

Jim Meyering jim at meyering.net
Thu Mar 31 06:29:49 UTC 2011


Pete Zaitcev wrote:
> On Mon, 28 Mar 2011 22:39:34 +0200
> Jim Meyering <jim at meyering.net> wrote:
>
>> +++ b/.gitignore
>> @@ -35,6 +35,7 @@
>>  /qparser.h
>>  /stamp-h1
>>  /t/*.log
>> +/t/lock-dir
>>  ChangeLog
>>  ID
>>  INSTALL
>
> Jim, "make distcheck" ends with this:
>
> rm -f Makefile
> ERROR: files left in build directory after distclean:
> ./t/lock-dir/m-27020/pid
> ./t/lock-dir/i-9095/pid
> ./t/lock-dir/m-27022/pid
> ./t/lock-dir/m-27019/pid
> ./t/lock-dir/i-9096/pid
> ./t/lock-dir/i-9097/pid
> ./t/lock-dir/i-9099/pid
> ./t/lock-dir/i-9098/pid
> ./t/lock-dir/m-27021/pid
> make[1]: *** [distcleancheck] Error 1
> make[1]: Leaving directory `/q/zaitcev/hail/iwhd-tip/iwhd-0.91.105-defd/_build'
> make: *** [distcheck] Error 1

Hi Pete,
Thanks for the heads up.
The usual clean mechanism works only for non-directories.

Here's the fix:

>From dcc96fb823243daeca938772b9a8b56592892d5b Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Thu, 31 Mar 2011 08:28:14 +0200
Subject: [PATCH] maint: remove lock-dir so that "make distcheck" passes again

* t/Makefile.am (clean-local): New rule, to remove temporary lock-dir.
Reported by Pete Zaitcev.
---
 t/Makefile.am |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/t/Makefile.am b/t/Makefile.am
index 6ffdfc8..a671c05 100644
--- a/t/Makefile.am
+++ b/t/Makefile.am
@@ -22,7 +22,9 @@ TESTS =						\
   auto

 lock_dir = $(abs_builddir)/lock-dir
-CONFIG_CLEAN_FILES = lock-dir
+clean-local:
+	$(AM_V_GEN)rm -rf "$(lock_dir)"
+
 .PHONY: prereq
 prereq:
 	$(AM_V_GEN)rm -rf "$(lock_dir)" && mkdir "$(lock_dir)"
--
1.7.4.2.662.gcbd0


More information about the iwhd-devel mailing list