[PATCH] maint: avoid new syntax-check failure

Jim Meyering jim at meyering.net
Fri Mar 11 18:25:45 UTC 2011


This fixes a harmless nit:

>From 845e42fc5c14ce56e8c48d53aa9bb3eeca1be6a8 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Fri, 11 Mar 2011 19:05:12 +0100
Subject: [PATCH] maint: avoid new syntax-check failure

* iwhd.init.in: Use "printf %s" in place of "echo -n".
Technically, echo -n is fine, since we know we're using bash,
but it's easier/cleaner to make this change than to exempt
this single file from the failing "make syntax-check".
---
 iwhd.init.in |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/iwhd.init.in b/iwhd.init.in
index bf57662..59d4032 100644
--- a/iwhd.init.in
+++ b/iwhd.init.in
@@ -68,15 +68,15 @@ start() {
     # This is a bit kludgey.  We'll use the standard daemon
     # framework once iwhd knows how to daemonize itself.
     test -f $PIDFILE && kill -0 $(cat $PIDFILE) 2>/dev/null \
-        && { echo -n $"$PROCESS appears to already be running"
+        && { printf %s $"$PROCESS appears to already be running"
              echo_failure; echo; return 1; }
     mkdir -p @localstatedir@/cache/iwhd
     rm -rf @localstatedir@/cache/iwhd/*
-    echo -n $"waiting for mongod to listen on $MONGOD_SERVER_SPEC"
+    printf %s $"waiting for mongod to listen on $MONGOD_SERVER_SPEC"
     wait_for_mongod $MONGOD_N_SECONDS && echo_success || echo_failure
     echo

-    echo -n $"Starting $SERVICE daemon: "
+    printf %s $"Starting $SERVICE daemon: "
     $PROCESS -c "$CONFIG_JS" $IWHD_ARGS > /var/log/iwhd.log 2>&1 &
     pid=$!
     RETVAL=$?
@@ -106,7 +106,7 @@ restart() {
 }

 reload() {
-    echo -n $"Reloading $SERVICE configuration: "
+    printf %s $"Reloading $SERVICE configuration: "

     killproc -p $PIDFILE $PROCESS -HUP
     RETVAL=$?
--
1.7.4.1.299.ga459d


More information about the iwhd-devel mailing list