minor rpmlint, fyi -- and specfile patch
Jim Meyering
jim at meyering.net
Wed Jun 8 16:13:05 UTC 2011
At first I couldn't build "make rpm" today.
It was failing like this:
extracting debug info from /h/j/rpmbuild/BUILDROOT/iwhd-0.95.12.8c49.dirty-1.fc15
.x86_64/usr/bin/dc-vmware-image
*** ERROR: No build ID note found in /h/j/rpmbuild/BUILDROOT/iwhd-0.95.12.8c49.dirty-1.fc15.x86_64/usr/bin/dc-vmware-image
error: Bad exit status from /var/tmp/rpm-tmp.qtHFFg (%install)
Seeing that I looked at the spec file and noticed a minor problem.
That new program name wasn't listed in the %files section.
Patch below.
Finally, I worked around the "No build ID note..." problem by doing this:
make clean && make LDFLAGS='-Wl,--build-id' && make rpm
I'll put that in the rpm rule, eventually.
Once I built RPMs, I ran "rpmlint" which showed some new problems,
none of which are terribly high priority. I'm listing them here
in case someone finds time to address them before I do.
E.g., the missing man pages will be automatically generated
via help2man, just as is already done for iwhd. That won't take long.
$ rpmlint ~/rpmbuild/RPMS/x86_64/iwhd-0.95.12.8c49-1.fc15.x86_64.rpm
iwhd.x86_64: W: spelling-error %description -l en_US Deltacloud -> Delta cloud, Delta-cloud, Thundercloud
iwhd.x86_64: W: incoherent-version-in-changelog 0.90-1 ['0.95.12.8c49-1.fc15', '0.95.12.8c49-1']
iwhd.x86_64: W: non-conffile-in-etc /etc/iwhd/conf.js
iwhd.x86_64: E: zero-length /usr/share/doc/iwhd-0.95.12.8c49/AUTHORS
iwhd.x86_64: W: no-manual-page-for-binary dc-vmware-image
iwhd.x86_64: W: no-manual-page-for-binary dc-rhev-image
iwhd.x86_64: W: empty-%post
iwhd.x86_64: E: postin-without-chkconfig /etc/rc.d/init.d/iwhd
iwhd.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/iwhd
iwhd.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/iwhd
iwhd.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/iwhd
iwhd.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/iwhd
iwhd.x86_64: W: service-default-enabled /etc/rc.d/init.d/iwhd
1 packages and 0 specfiles checked; 3 errors, 10 warnings.
[Exit 64]
>From 8c492cde443ea04cf0ad2316d3c56f4b06928b0c Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Wed, 8 Jun 2011 16:59:55 +0200
Subject: [PATCH] maint: add dc-vmware-image to the spec file
* iwhd.spec.in (%files): Add %{_bindir}/dc-vmware-image.
---
iwhd.spec.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/iwhd.spec.in b/iwhd.spec.in
index 660e3a0..5d39ffc 100644
--- a/iwhd.spec.in
+++ b/iwhd.spec.in
@@ -60,6 +60,7 @@ rm -rf %{buildroot}
%doc AUTHORS COPYING README NEWS
%{_bindir}/iwhd
%{_bindir}/dc-rhev-image
+%{_bindir}/dc-vmware-image
%{_mandir}/man8/iwhd.8*
%{_sysconfdir}/rc.d/init.d/iwhd
%{_sysconfdir}/iwhd/conf.js
--
1.7.6.rc0.293.g40857
More information about the iwhd-devel
mailing list