[PATCH] dc-vmware-image: don't ignore setenv failure

Jim Meyering jim at meyering.net
Wed Jun 1 07:03:24 UTC 2011


Given that the consequences of failure to set than environment
variable are so subtle, we must not ignore it:

>From d8739ac933bcdfb0ee0b88fa078587bddfba1fbd Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Wed, 1 Jun 2011 09:00:44 +0200
Subject: [PATCH] dc-vmware-image: don't ignore setenv failure

* dc-vmware-image.c (main): Don't ignore setenv failure.
---
 dc-vmware-image.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/dc-vmware-image.c b/dc-vmware-image.c
index 273b2bf..5841b49 100644
--- a/dc-vmware-image.c
+++ b/dc-vmware-image.c
@@ -2514,7 +2514,11 @@ int main(int argc, char **argv, char **envp)
 	 * Alas, that breaks because NS_Initialize fails on second run.
 	 * So, layering violation it is.
 	 */
-	setenv("NSS_STRICT_NOFORK", "DISABLED", 1);
+	if (setenv("NSS_STRICT_NOFORK", "DISABLED", 1) != 0) {
+		fprintf(stderr, "setenv failed\n");
+		exit(EXIT_FAILURE);
+	}
+
 	if (curl_global_init(CURL_GLOBAL_ALL) != 0)
 		exit(EXIT_FAILURE);

--
1.7.5.2.660.g9f46c


More information about the iwhd-devel mailing list