[patch] Add logrotate support

Mark McLoughlin markmc at redhat.com
Tue Jul 12 05:17:58 UTC 2011


On Mon, 2011-07-11 at 17:36 -0600, Pete Zaitcev wrote:
> On Fri, 08 Jul 2011 14:59:56 +0200
> Jim Meyering <jim at meyering.net> wrote:
> 
> >   +		error(_("Failed to open log file %s: %s\n"),
> >   +		      path, strerror(errno));
> > 
> > the two leading integer arguments to "error" (usu. "0, 0,") have
> > been omitted.  I would expect gcc -Wformat to catch that.
> 
> Perhaps this explains why:
> 
> > #define error(status, err, fmt, args...) log_msg(LOG_ERR, fmt, ##args)
> 
> Personally, I am against such insiduous obfuscation by redefining
> library functions. We out to comb the source and replace calls
> to error() with calls to log_msg.

Yep, I was only suggesting re-defining it as a stepping stone

Cheers,
Mark.



More information about the iwhd-devel mailing list