[patch] Add logrotate support
Pete Zaitcev
zaitcev at redhat.com
Mon Jul 11 23:32:09 UTC 2011
On Mon, 11 Jul 2011 16:19:45 -0600
Pete Zaitcev <zaitcev at redhat.com> wrote:
> On Mon, 11 Jul 2011 22:09:36 +0100
> Mark McLoughlin <markmc at redhat.com> wrote:
>
> > > If it is not using syslog, what is that LOG_DEBUG for?
> >
> > It's an enum value that has nothing to do with syslog, representing the
> > importance of the message being printed
>
> What is the point of 1. having it at all, 2. using a value from syslog.h?
> By reusing syslog value, you are making every module include <syslog.h>.
Actually it's even worse:
> typedef enum {
> LOG_DEBUG = 0,
> LOG_INFO,
> LOG_WARN,
> LOG_ERR,
> } log_level_t;
If anyone decides to implement a syslog back-end, it is going to be
interesting and confusing.
-- Pete
More information about the iwhd-devel
mailing list